Avoid importing everything when given an empty relation #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can currently call `import` and `import!` directly on an index. If
these methods are called without arguments, the index imports all data
matching the type definition.
If these methods are called with an argument, ex.
`UsersIndex.import(User.where('rating > 100'))`, only the given scope or
array will be imported into the index.
If these methods are called with an argument, but that argument is empty
(for example `User.where('rating > 100')` returns an empty relation),
the methods were behaving as if they had no args (importing all the data
for an index).
This is undesired behavior, as the expectation should be for an import
with an argument that is empty to import nothing.
The changes proposed here mirror the changes created in this
[commit](2eeff14), so that the behavior of doing `UsersIndex.import([])` is the same as doing `UsersIndex::User.import([])`.
rabotyaga
approved these changes
Feb 4, 2021
dalthon
force-pushed
the
empty-relation-import
branch
3 times, most recently
from
c8a4b46
to
e1bb4a2
Compare
dalthon
force-pushed
the
empty-relation-import
branch
from
e1bb4a2
to
b22389c
Compare
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
cyucelen
pushed a commit
to cyucelen/chewy
that referenced
this pull request
Jan 28, 2023
* Avoid importing everything when given an empty relation * Add spec to cover empty relations Co-authored-by: JF Lalonde <lalondej88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a rebase of #698 with one more spec added to cover empty relations.