Patch ElasticSearch deprecation warning #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfonsoUceda
approved these changes
Jan 28, 2021
mrzasa
approved these changes
Jan 28, 2021
Bhacaz
force-pushed
the
correct_es_6_delete_by_query_warning
branch
from
8828d62
to
61a59e7
Compare
rabotyaga
approved these changes
Jan 28, 2021
Bhacaz
added a commit
to petalmd/chewy
that referenced
this pull request
Jan 29, 2021
Add a safe guard to not call ES client delete with an empty string. Bug introduced with toptal#735
Bhacaz
added a commit
to petalmd/chewy
that referenced
this pull request
Jan 29, 2021
Add a safe guard to not call ES client delete with an empty string. Bug introduced with toptal#735
Bhacaz
added a commit
to petalmd/chewy
that referenced
this pull request
Jan 29, 2021
Add a safe guard to not call ES client delete with an empty string. Bug introduced with toptal#735
Bhacaz
added a commit
to petalmd/chewy
that referenced
this pull request
Jan 29, 2021
Add a safe guard to not call ES client delete with an empty string. Bug introduced with toptal#735
Bhacaz
added a commit
to petalmd/chewy
that referenced
this pull request
Jan 29, 2021
Add a safe guard to not call ES client delete with an empty string. Bug introduced with toptal#735
Bhacaz
added a commit
to petalmd/chewy
that referenced
this pull request
Jan 29, 2021
Add a safe guard to not call ES client delete with an empty string. Bug introduced with toptal#735
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, since some peoples seems to work/wish to make Chewy compatible with ElasticSearch 6-7, here is a small PR to fix the deprecation warning from ElasticSearch. It seems to be a good first step.