Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rails version in CI matrix #733

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Conversation

Bhacaz
Copy link
Contributor

@Bhacaz Bhacaz commented Jan 14, 2021

Hi, with all the new releases of Ruby and Rails. I thought it might be interesting update the Rails version in the matrix CI.

I also removed the unsupported version of Ruby and Rails from the CI matrix.

@Bhacaz Bhacaz force-pushed the update_ci_matrix branch 2 times, most recently from 497dcb0 to bbfa09d Compare January 27, 2021 13:25
@rabotyaga
Copy link
Contributor

@Bhacaz Thank you very much for your effort!
Could you please also apply this small patch, it will allow specs with activesupport6.1 to pass:

--- a/lib/chewy/type/witchcraft.rb
+++ b/lib/chewy/type/witchcraft.rb
@@ -58,7 +58,7 @@ module Chewy
       private

         def alicorn
-          @alicorn ||= class_eval <<-RUBY, __FILE__, __LINE__ + 1
+          @alicorn ||= singleton_class.class_eval <<-RUBY, __FILE__, __LINE__ + 1
             -> (locals, object0, crutches) do
               #{composed_values(@type.root, 0)}
             end

They are failing, as in 6.0 there was a line

require "active_support/core_ext/kernel/singleton_class"

in lib/active_support/deprecation/instance_delegator.rb, and in 6.1 it is gone.

@Bhacaz
Copy link
Contributor Author

Bhacaz commented Jan 27, 2021

@rabotyaga I was searching in ActiveSupport without success what change was causing that error. Thank you 😊

@rabotyaga rabotyaga merged commit ac0e5ef into toptal:master Jan 27, 2021
@rabotyaga
Copy link
Contributor

rabotyaga commented Jan 27, 2021

Thanks @Bhacaz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants