Allow configuration of Active Job queue name #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrzasa
commented
Mar 27, 2020
| @@ -33,7 +33,7 @@ def leave | |||
| private | |||
|
|
|||
| def sidekiq_queue | |||
| Chewy.settings.fetch(:sidekiq, {})[:queue] || 'chewy' | |||
| Chewy.settings.dig(:sidekiq, :queue) || 'chewy' | |||
There was a problem hiding this comment.
drive-by improvement
LTe
approved these changes
Mar 30, 2020
iprlic
approved these changes
Mar 30, 2020
mrzasa
force-pushed
the
configure-active-job-queue
branch
from
52dc8cb
to
a4b84ca
Compare
|
WIP until CI is fixed |
mrzasa
force-pushed
the
configure-active-job-queue
branch
from
a4b84ca
to
b23e97d
Compare
mrzasa
force-pushed
the
configure-active-job-queue
branch
from
b23e97d
to
f11a51a
Compare
mrzasa
commented
Jun 1, 2020
| active_job_settings = Chewy.settings[:active_job] | ||
| Chewy.settings[:active_job] = {queue: 'low'} | ||
| Chewy.strategy(:bypass) { example.run } | ||
| Chewy.settings[:active_job] = active_job_settings |
There was a problem hiding this comment.
making the tests order-independent
pyromaniac
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can configure sidekiq queue in settings, but ActiveJob queue name was hadcoded. This PR changes this and allows configuring AJ queue by setting
Chewy.settings[:active_job][:queue].