Clear the scroll by id after completing scroll_batches #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amoslanka thank you for your PR, it was just rebased and merged! |
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElasticSearch has settings that limit the number of concurrent scrolls on the cluster. Scrolls are cleared automatically after the scroll ttl (eg, "1m") but I've found that iterating a lot of data in a lot of parallel jobs makes it easy to hit this limit. This may be avoided by staggering parallelism differently or by setting shorter scroll ttls, but it seems to also make sense to clear out the old scrolls when the use of scroll_batches is complete.