Insert request_strategy middleware before ActionDispatch::ShowExceptions #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xceptions It used to be included after Rack::Logger. However, people can use other loggers that swap Rack::Logger so on a moment when Chewy insertion is executed there is no Rack::Logger in the chain.
conf
approved these changes
Jul 25, 2019
pyromaniac
approved these changes
Sep 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Chewy inserts request_strategy middleware after Rails::Rack::Logger. However people can use their custom loggers or use other gems, for instance https://github.com/rocketjob/rails_semantic_logger
Such gems swap
Rails::Rack::Loggermiddleware with their implementations so on a moment when Chewy wants to insert its middleware afterRails::Rack::Loggerit doesn't exist in the chain.In this PR instead of relying on
Rails::Rack::Loggerexistence we place Chewy middleware beforeActionDispatch::ShowExceptionsthat goes right after loggers.This also fixes this #286