Add query string parameter support #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattzollinhofer
force-pushed
the
add-query-string-parameter-support
branch
4 times, most recently
from
111f1d3
to
af46a81
Compare
Per ES docs: search_type, request_cache, and the allow_partial_search_results
should not be in the body. They should be sent as query string parameters. My
understanding is that chewy should act like this:
$ IssuesIndex.request_cache(true).render
# good (new)
$ {:index=>["issues"], :type=>["issue"], :body=>{}, :request_cache=>true}
# bad (old)
$ {:index=>["issues"], :type=>["issue"], :body=>{:request_cache=>true}
I believe this resolves issue toptal#586 and part of issue toptal#642.
(https://www.elastic.co/guide/en/elasticsearch/reference/6.4/search-request-body.html#_parameters_4)
Just adding this for completeness. I didn't really test using this so you can definitely remove this if it's not wanted. This support was added in ES 6.3. https://www.elastic.co/blog/this-week-in-elasticsearch-and-apache-lucene-2018-02-05
mattzollinhofer
force-pushed
the
add-query-string-parameter-support
branch
from
af46a81
to
5f2d8f8
Compare
|
Oh, I don't really understand this. https://github.com/elastic/elasticsearch-ruby/blob/master/elasticsearch-api supposed to handle this. But okay, let's merge it. |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per ES docs: search_type, request_cache, and the allow_partial_search_results
should not be in the body. They should be sent as query string parameters. (https://www.elastic.co/guide/en/elasticsearch/reference/6.4/search-request-body.html#_parameters_4)
My understanding is that chewy should act like this:
I believe this resolves #586 and part of #642.
This is my first PR to this repo so please let me know if you'd like any changes. The second commit (Adding AllowPartialSearchResults parameter) is definitely optional as it supports an ES 6 feature. What do you think?