Rails::VERSION is more accurate check for presence of Rails #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone check if those failing tests on CI are PR related, or those are floating specs? I ran those tests locally and they passed... |
nattfodd
force-pushed
the
rails_dependency_fixed
branch
3 times, most recently
from
29c75f1
to
8a79c2c
Compare
|
Ok, I've investigated failing test case - it's definitely not related to the fix itself. It seems it's something about race condition here https://github.com/toptal/chewy/blob/master/spec/chewy/index/actions_spec.rb#L501-L521 |
Closed
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Railsmodule can be defined without actual Rails gem.I work on a Sinatra project, which has ActionView in dependencies.
ActionViewitself does not depend on Rails, but it has rails-html-sanitizer and rails-dom-testing gems in dependencies, which both defineRailsmodule.Therefore, check
defined?(Rails)isn't fully valid, and requires hacking on the client app side to make it work (i.e. definingRails.rootmethod and havingconfig/chewy.ymlfile)