Avoid Elasticsearch index updates when passing empty reflections #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyromaniac
reviewed
Dec 22, 2017
| @@ -126,6 +126,7 @@ def compose(object, crutches = nil, fields: []) | |||
| private | |||
|
|
|||
| def import_routine(*args) | |||
| return if args.first.blank? && !args.first.nil? | |||
There was a problem hiding this comment.
What if only the options are passed?
It probably makes sense to do this check after args.extract_options!
There was a problem hiding this comment.
In that case, given that options aren't empty, this would work the same as Index.import! (without objects, with imports everything under the scope). Right?
There was a problem hiding this comment.
I don't mind changing this to make it less confusing though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
[]or another equivalent of an empty reflection toIndex.import!makes two requests to the corresponding Elasticsearch index.GET /indexandPUT /indexto ensure whether the index exists, and to update the index.Given a complicated record which triggers many Chewy index updates on associations, this might result in N+1 requests, which might be undesired.
This change adds avoids these requests whenever the reflection is empty.