Fixes logic error in index settings #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only occurs if you have these two settings enabled (and probably any other config option that saves/restores index settings): * reset_disable_refresh_interval * reset_no_replicas
|
Hey, great finding! Can you add a spec for the case, please? |
|
@pyromaniac How's that look? |
pyromaniac
reviewed
Nov 2, 2017
|
|
||
| specify 'uses empty index settings if not defined' do | ||
| allow(Chewy).to receive(:wait_for_status).and_return(nil) | ||
| allow(CitiesIndex).to receive(:settings_hash).and_return({}) |
There was a problem hiding this comment.
Did you check if it fails without your fix?
There was a problem hiding this comment.
Yeah, the root cause was because of spec/spec_helper.rb:27 ; if the :index option isn't set, then the tests fail because Index#index_settings tries to access it.
pyromaniac
reviewed
Nov 2, 2017
This reverts commit 536b147.
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a logic error in the code that extracts an index's settings from the settings hash.
Only occurs if you have these two settings enabled (and probably any
other config option that saves/restores index settings):