Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper: missed check in highlight method #567

Merged
merged 1 commit into from
Aug 27, 2017

Conversation

heartfulbird
Copy link

@heartfulbird heartfulbird commented Aug 25, 2017

Hello, it is very helpful library! Thank you so much)

It seems you missed check with your own method in wrapper highlight method.
I'm not sure is it good practice or not to use elasticsearch without query or use it with wildcard, but in this case we need to check that _data contains key "highlights" and _data['highlights'] contains key which is equal to attribute name.
Moreover - you already have this method!)

@pyromaniac
Copy link
Contributor

Makes sense actually, thanks!

@pyromaniac pyromaniac merged commit 756e31a into toptal:master Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants