Add ability to skip index existence checks on each import #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-kintsel
force-pushed
the
make-index-existance-checks-configurable
branch
from
e8462fd
to
7f66cdd
Compare
sergey-kintsel
changed the title
sergey-kintsel
force-pushed
the
make-index-existance-checks-configurable
branch
from
7f66cdd
to
4e5694e
Compare
pyromaniac
reviewed
Mar 14, 2017
lib/chewy.rb
Outdated
|
|
||
| def create_indices | ||
| eager_load! | ||
| Chewy::Index.descendants.each(&:create) |
There was a problem hiding this comment.
create! would be better, also, create_indices!
There was a problem hiding this comment.
I'll add both just to be able to use what we need
pyromaniac
reviewed
Mar 14, 2017
lib/chewy/type/import.rb
Outdated
| @@ -237,6 +237,11 @@ def fetch_indexed_objects(objects) | |||
|
|
|||
| indexed_objects | |||
| end | |||
|
|
|||
| def assure_index_existence(index_options) | |||
| return if Chewy.configuration[:strict_index_creation] | |||
There was a problem hiding this comment.
can we invert it and call skip_index_creation_on_import?
sergey-kintsel
force-pushed
the
make-index-existance-checks-configurable
branch
3 times, most recently
from
471f4a0
to
c6be99f
Compare
It is configurable by `skip_index_creation_on_import` parameter in `config/chewy.yml`.
sergey-kintsel
force-pushed
the
make-index-existance-checks-configurable
branch
from
c6be99f
to
04d2fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is configurable by
skip_index_creation_on_importparameter inconfig/chewy.yml.