-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the track_scores
option to the query
#417
Conversation
BTW: I would add somewhere in the readme line how to add unsupported criterias, like: PlacesSearch.
index.
filter(filters).
tap { |v| v.criteria.update_request_options(track_scores: true) } Small remark: if it will be right after the index, criteria will be written into the |
Hm, as for remark - you probably can do Can you add specs for this so I could merge it, please? Great contribution, thanks! |
@pyromaniac tests were added. |
@pyromaniac please merge :) |
Oh boy, I missed this. Can you please fix rubocop offences and I'll merge it right away. Sorry for the delay. |
@pyromaniac where do I can see rubocop offences? |
just run |
`_score` to be computed and tracked even when there are no `_score` in sort.
7bbb28e
to
54c5c02
Compare
@pyromaniac right, haven't noticed my master isn't synced with origin master |
Perfect, thanks! |
_score
to be computed and tracked even when there are no_score
in sort.More here: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-sort.html