Add unlimited method to fetch all records from ES #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-kintsel
force-pushed
the
add-fetch-all
branch
2 times, most recently
from
61c12c2
to
aa6af74
Compare
| @@ -5,7 +5,7 @@ class Query | |||
| class Criteria | |||
| include Compose | |||
| ARRAY_STORAGES = [:queries, :filters, :post_filters, :sort, :fields, :types, :scores] | |||
| HASH_STORAGES = [:options, :request_options, :facets, :aggregations, :suggest, :script_fields] | |||
| HASH_STORAGES = [:options, :request_options, :facets, :aggregations, :suggest, :script_fields, :search_options] | |||
There was a problem hiding this comment.
move it before request_options please
sergey-kintsel
force-pushed
the
add-fetch-all
branch
2 times, most recently
from
e41928e
to
8a9a6bb
Compare
| @@ -96,13 +96,15 @@ | |||
| specify { expect(subject.limit(10)).not_to eq(subject) } | |||
| specify { expect(subject.limit(10).criteria.request_options).to include(size: 10) } | |||
| specify { expect { subject.limit(10) }.not_to change { subject.criteria.request_options } } | |||
| specify { expect(subject.offset { 20/2 }.criteria.request_body[:body]).to include(size: 10) } | |||
sergey-kintsel
force-pushed
the
add-fetch-all
branch
from
8a9a6bb
to
b3c79a6
Compare
|
Awesome! Thanks! |
|
@sergey-kintsel does this require ES 5.x or a special max_results_window value? Tried to use it locally with my ES 2.3 installation, and it complains about going beyond the max results window |
|
@binarydev Hi! It does not require the latest ES, but it does require max_results_window. The problem is that most likely you are trying to load too much data. This method is a bit unsafe I would say. So, if you really need that much data - change max results window |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It removes offset and sets response limit to the total_count value