Add support for raw_import flag #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,6 +55,17 @@ def scope_where_ids_in(scope, ids) | |||
| scope.where(target_id.in(Array.wrap(ids))) | |||
| end | |||
|
|
|||
| def raw_default_scope_where_ids_in(ids) | |||
| sql = default_scope.where(target_id.in(Array.wrap(ids))).to_sql | |||
There was a problem hiding this comment.
default_scope_where_ids_in(ids).to_sql?
DNNX
force-pushed
the
raw-import
branch
2 times, most recently
from
3037516
to
b7abbd9
Compare
|
@pyromaniac please have a look |
DNNX
changed the title
This flag allows to avoid ActiveRecord instantiation on big imports, which can speed up chewing time significantly.
|
@DNNX - thanks for a great feature. I'm probably a bit stupid (very newbie on ActiveRecord et al) but I am struggling to get it working based on the information you wrote there in the docs, but I cannot really understand how to get my head around it. I have my ActiveRecord model set up etc, and via the activerecord-import gem an extra |
levent
pushed a commit
to levent/chewy
that referenced
this pull request
Nov 1, 2016
This flag allows to avoid ActiveRecord instantiation on big imports, which can speed up chewing time significantly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
raw_importoption was added. Basically, it allows to avoid unnecessary serialization->deserialization cycles when it matters. Often, a lot of time is spent on creating AR objects, typecasting fields, etc. But eventually, it all gets converted back to strings. So why waste resources on unnecessary conversions. Raw Import is added just for this purpose. On one of our indexes, using this feature shanked index reset time from 7.5 minutes to 4.5 minutes.The details on how to use this feature can be found in the updated documentation.