Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append newline after each bulk request #374

Merged
merged 1 commit into from
Apr 22, 2016
Merged

Append newline after each bulk request #374

merged 1 commit into from
Apr 22, 2016

Conversation

0x0badc0de
Copy link
Contributor

Added a test at spec/chewy/type/import_spec.rb:73 which fails as following:

  1) Chewy::Type::Import.import :bulk_size 
     Failure/Error: result = client.bulk options.merge(header).merge(body: body)

     Elasticsearch::Transport::Transport::Errors::BadRequest:
       [400] {"error":{"root_cause":[{"type":"action_request_validation_exception","reason":"Validation Failed: 1: no requests added;"}],"type":"action_request_validation_exception","reason":"Validation Failed: 1: no requests added;"},"status":400}

Looks like to be known issue - need a newline at the end of bulk entry, see
https://discuss.elastic.co/t/elastic-search-bulk-post-testing/24065/4
http://stackoverflow.com/a/22997612
This PR adds missing newline so test passes.

@pyromaniac pyromaniac merged commit d354acf into toptal:master Apr 22, 2016
@pyromaniac
Copy link
Contributor

Awesome, thanks!

@0x0badc0de 0x0badc0de deleted the fix-bulk-size branch April 22, 2016 08:47
levent pushed a commit to levent/chewy that referenced this pull request Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants