Append newline after each bulk request #374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test at
spec/chewy/type/import_spec.rb:73
which fails as following:Looks like to be known issue - need a newline at the end of bulk entry, see
https://discuss.elastic.co/t/elastic-search-bulk-post-testing/24065/4
http://stackoverflow.com/a/22997612
This PR adds missing newline so test passes.