Add type specific settings #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +51,10 @@ def self.scopes | |||
| public_methods - Chewy::Type.public_methods | |||
| end | |||
|
|
|||
| def self.settings(params) | |||
| self._settings = self._settings.deep_merge(params) | |||
There was a problem hiding this comment.
should params keys be restricted to "known settings"? Like:
KNOWN_SETTINGS = %i[import_options]
...
def self.settings(params)
unknown_settings = params.each_key.select { |key| !KNOWN_OPTIONS.include?(key) }
raise ArgumentError, "Unknown settings: #{unknown_settings.join(', ')}" unless unknown_settings.empty?
self._settings = self._settings.deep_merge(params)
end
There was a problem hiding this comment.
Why not? Also, http://apidock.com/rails/Hash/assert_valid_keys
|
I think |
It allows to set default options for import per type.
barthez
force-pushed
the
per-type-settings
branch
from
ea30e3a
to
82828e5
Compare
|
@pyromaniac Is it better now? |
|
Yeah, much better, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #340 adding per type settings for import options would be a nice idea. It allows to tune batch size for each defined type specifically.
@pyromaniac What do you think about it?