Better error handling in Chewy::Strategy#wrap #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing non-exising strategy to Chewy::Strategy#wrap caused unclear error: "Can't pop root strategy". Now, push and wrap give back better error when strategy is missing.
barthez
force-pushed
the
better-error-handling-in-strategy-wrap
branch
from
6ad7b9c
to
dea0a5d
Compare
|
It turns out that with mongoid we can observe strange behavior of I've introduced small workaround which handle that case. |
pyromaniac
added a commit
that referenced
this pull request
Jan 6, 2016
…y-wrap Better error handling in Chewy::Strategy#wrap
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing non-exising strategy to Chewy::Strateg#wrap caused unclear error: "Can't pop root strategy". Now, push and wrap give back better error when strategy is missing.