Fix keyword arguments handling in names scopes (#836)

toptal · Feb 11, 2022 · 4b07cd8 · 4b07cd8
1 parent 876d51c
commit 4b07cd8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/chewy/search.rb b/lib/chewy/search.rb
@@ -84,9 +84,10 @@ def build_search_class(base)
       def delegate_scoped(source, destination, methods)
         methods.each do |method|
           destination.class_eval do
-            define_method method do |*args, **kwargs, &block|
-              scoping { source.public_send(method, *args, **kwargs, &block) }
+            define_method method do |*args, &block|
+              scoping { source.public_send(method, *args, &block) }
             end
+            ruby2_keywords method
           end
         end
       end

diff --git a/spec/chewy/search_spec.rb b/spec/chewy/search_spec.rb
@@ -48,7 +48,7 @@ def self.by_name(index)
           filter { match name: "Name#{index}" }
         end
 
-        def self.by_rating_with_kwargs(value, options:)
+        def self.by_rating_with_kwargs(value, options:) # rubocop:disable Lint/UnusedMethodArgument
           filter { match rating: value }
         end