This repository was archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
refactor: update error management and config/process #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac1916d
to
62e444d
Compare
61cb270
to
e9caebb
Compare
fe37e3f
to
dc2454f
Compare
d82e2a0
to
2bf25cd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 71.24% 70.59% -0.66%
==========================================
Files 226 226
Lines 12438 12418 -20
==========================================
- Hits 8862 8766 -96
- Misses 3576 3652 +76 ☔ View full report in Codecov by Sentry. |
4e12073
to
af865ae
Compare
b6fce4a
to
6713886
Compare
af865ae
to
4e678be
Compare
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
4e678be
to
719c5fc
Compare
hadjiszs
approved these changes
Mar 4, 2024
gruberb
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor naming changes.
dvdplm
approved these changes
Mar 4, 2024
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates how we deal with config and errors during the start of the node.
Basically, removing and refactoring
Config
management and responsibility of parsing, removing someBox<dyn Error>
to proper error handling.PR Checklist: