Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

refactor: update error management and config/process #460

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

Freyskeyd
Copy link
Member

@Freyskeyd Freyskeyd commented Feb 16, 2024

Description

This PR updates how we deal with config and errors during the start of the node.
Basically, removing and refactoring Config management and responsibility of parsing, removing some Box<dyn Error> to proper error handling.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd force-pushed the feature/tp-853 branch 2 times, most recently from ac1916d to 62e444d Compare February 19, 2024 13:53
@Freyskeyd Freyskeyd force-pushed the refactor/process-and-errors branch from 61cb270 to e9caebb Compare February 19, 2024 13:58
@Freyskeyd Freyskeyd force-pushed the feature/tp-853 branch 7 times, most recently from fe37e3f to dc2454f Compare February 19, 2024 15:04
@Freyskeyd Freyskeyd force-pushed the refactor/process-and-errors branch 6 times, most recently from d82e2a0 to 2bf25cd Compare February 20, 2024 15:18
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 78.78788% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 70.59%. Comparing base (d8db631) to head (ab419d0).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/topos-node/src/lib.rs 63.63% 12 Missing ⚠️
crates/topos-config/src/node.rs 81.63% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   71.24%   70.59%   -0.66%     
==========================================
  Files         226      226              
  Lines       12438    12418      -20     
==========================================
- Hits         8862     8766      -96     
- Misses       3576     3652      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd force-pushed the refactor/process-and-errors branch 2 times, most recently from 4e12073 to af865ae Compare February 21, 2024 09:44
@Freyskeyd Freyskeyd force-pushed the feature/tp-853 branch 2 times, most recently from b6fce4a to 6713886 Compare February 29, 2024 15:15
Base automatically changed from feature/tp-853 to main March 1, 2024 20:18
@Freyskeyd Freyskeyd force-pushed the refactor/process-and-errors branch from af865ae to 4e678be Compare March 1, 2024 20:22
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd force-pushed the refactor/process-and-errors branch from 4e678be to 719c5fc Compare March 1, 2024 20:28
@Freyskeyd Freyskeyd marked this pull request as ready for review March 1, 2024 20:32
@Freyskeyd Freyskeyd requested a review from a team as a code owner March 1, 2024 20:32
@Freyskeyd Freyskeyd requested review from dvdplm and hadjiszs March 1, 2024 20:32
Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor naming changes.

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd merged commit cc0c7b5 into main Mar 5, 2024
22 checks passed
@Freyskeyd Freyskeyd deleted the refactor/process-and-errors branch March 5, 2024 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants