fix: fixing release notification #423

Freyskeyd · 2024-01-03T10:58:55Z

Description

This PR aims to fix the redundant notifications emitted when creating a release.

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added or updated tests that comprehensively prove my change is effective or that my feature works

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>

dvdplm · 2024-01-05T13:51:43Z

Maybe add a comment saying "# No notifications for pre-releases" or something?

Freyskeyd force-pushed the chore/fixing-release-notification branch from 10c618a to 821e2a7 Compare January 3, 2024 17:28

Freyskeyd marked this pull request as ready for review January 3, 2024 17:29

Freyskeyd requested a review from a team as a code owner January 3, 2024 17:29

Freyskeyd requested review from dvdplm and atanmarko January 3, 2024 17:29

Freyskeyd force-pushed the chore/fixing-release-notification branch 2 times, most recently from 96650a5 to 4ec927f Compare January 3, 2024 18:10

Freyskeyd added 2 commits January 4, 2024 10:19

fix: fixing release notification

d85928d

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>

chore: filter prerelease

f7bb7ea

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>

Freyskeyd force-pushed the chore/fixing-release-notification branch from 4ec927f to f7bb7ea Compare January 4, 2024 09:19

atanmarko approved these changes Jan 4, 2024

View reviewed changes

dvdplm approved these changes Jan 5, 2024

View reviewed changes

Freyskeyd merged commit 7503fa7 into main Jan 5, 2024

Freyskeyd deleted the chore/fixing-release-notification branch January 5, 2024 18:14