Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

fix: return error from subprocesses #422

Merged
merged 4 commits into from
Jan 3, 2024
Merged

fix: return error from subprocesses #422

merged 4 commits into from
Jan 3, 2024

Conversation

atanmarko
Copy link
Member

Description

Return topos cli exit status with respect to edge subprocess status

Fixes TP-825

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko self-assigned this Dec 26, 2023
@atanmarko atanmarko requested a review from a team as a code owner December 26, 2023 16:08
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (c60170d) 68.00% compared to head (7e8b811) 67.55%.

Files Patch % Lines
crates/topos/src/components/node/mod.rs 50.00% 10 Missing ⚠️
crates/topos-sequencer/src/lib.rs 0.00% 2 Missing ⚠️
crates/topos-tce/src/lib.rs 0.00% 2 Missing ⚠️
...ates/topos/src/components/node/services/process.rs 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   68.00%   67.55%   -0.45%     
==========================================
  Files         220      220              
  Lines       11823    11841      +18     
==========================================
- Hits         8040     7999      -41     
- Misses       3783     3842      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atanmarko atanmarko requested a review from hadjiszs December 26, 2023 16:19
@atanmarko
Copy link
Member Author

Somehow polygon edge spawned process always returns ExitStatus(unix_wait_status(0)) despite the fact that error happened. I have tried other commands (ls) and their error is correctly propagated to topos cli exit

@atanmarko atanmarko merged commit 53b3229 into main Jan 3, 2024
@atanmarko atanmarko deleted the TP-825 branch January 3, 2024 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants