Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

chore: adding context on connection to self #411

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

Freyskeyd
Copy link
Member

Description

We saw some weird connection of one node to himself, leading to warnings. This PR aims to add some logs to find out why it is happening.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner December 16, 2023 10:20
@Freyskeyd Freyskeyd requested review from dvdplm and gruberb December 16, 2023 10:20
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e1b2ccf) 65.64% compared to head (effcc24) 65.65%.

Files Patch % Lines
crates/topos-p2p/src/runtime/handle_event.rs 64.28% 5 Missing ⚠️
crates/topos-tce/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   65.64%   65.65%           
=======================================
  Files         223      223           
  Lines       11888    11900   +12     
=======================================
+ Hits         7804     7813    +9     
- Misses       4084     4087    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd force-pushed the chore/adding-context-on-connection-to-self branch from 8ee5ac7 to effcc24 Compare December 16, 2023 19:33
@Freyskeyd Freyskeyd merged commit 3a799ac into main Dec 16, 2023
@Freyskeyd Freyskeyd deleted the chore/adding-context-on-connection-to-self branch December 16, 2023 20:52
@Freyskeyd Freyskeyd added this to the Soft-fork investigation milestone Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants