Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

feat: add batch message and update double echo #383

Merged
merged 8 commits into from
Nov 30, 2023
Merged

feat: add batch message and update double echo #383

merged 8 commits into from
Nov 30, 2023

Conversation

atanmarko
Copy link
Member

@atanmarko atanmarko commented Nov 23, 2023

Description

Cleanup double echo protoc from bincode serialization.
Refactor a bit message pasing

Fixes TP-788

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko self-assigned this Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (014ddf6) 62.79% compared to head (1416d68) 62.86%.
Report is 1 commits behind head on main.

Files Patch % Lines
crates/topos-p2p/src/runtime/handle_command.rs 71.42% 2 Missing ⚠️
...es/topos-p2p/src/runtime/handle_event/gossipsub.rs 83.33% 2 Missing ⚠️
crates/topos-p2p/src/behaviour/gossip.rs 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   62.79%   62.86%   +0.07%     
==========================================
  Files         219      219              
  Lines       11812    11793      -19     
==========================================
- Hits         7417     7414       -3     
+ Misses       4395     4379      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atanmarko atanmarko changed the title feat: refactor double echo feat: add batch message and update double echo Nov 29, 2023
@atanmarko atanmarko marked this pull request as ready for review November 29, 2023 10:32
@atanmarko atanmarko requested a review from a team as a code owner November 29, 2023 10:32
@atanmarko atanmarko merged commit f0bc90c into main Nov 30, 2023
@atanmarko atanmarko deleted the feat/TP-788 branch November 30, 2023 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants