Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

feat: use websocket stream block listener #371

Merged
merged 5 commits into from
Nov 15, 2023
Merged

feat: use websocket stream block listener #371

merged 5 commits into from
Nov 15, 2023

Conversation

atanmarko
Copy link
Member

@atanmarko atanmarko commented Nov 10, 2023

Description

Change block retrieval from the subnet node. Use websocket stream block subscription instead of timer.

Fixes TP-599

Additions and Changes

Old mechanism to retrieve block by number is kept for initial block sync on sequencer startup. When sync is performed, blocks are further received though block subscription stream.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko self-assigned this Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (4799cce) 60.92% compared to head (c035507) 60.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   60.92%   60.61%   -0.32%     
==========================================
  Files         233      233              
  Lines       12282    12352      +70     
==========================================
+ Hits         7483     7487       +4     
- Misses       4799     4865      +66     
Files Coverage Δ
crates/topos-sequencer-subnet-runtime/src/proxy.rs 0.00% <0.00%> (ø)
crates/topos-sequencer-subnet-client/src/lib.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atanmarko atanmarko marked this pull request as ready for review November 10, 2023 13:16
@atanmarko atanmarko requested a review from a team as a code owner November 10, 2023 13:16
@atanmarko atanmarko mentioned this pull request Nov 10, 2023
4 tasks
@atanmarko atanmarko merged commit ff92295 into main Nov 15, 2023
@atanmarko atanmarko deleted the feat/TP-599 branch November 15, 2023 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants