Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

fix: assert delivery test #350

Merged
merged 9 commits into from
Oct 30, 2023
Merged

fix: assert delivery test #350

merged 9 commits into from
Oct 30, 2023

Conversation

atanmarko
Copy link
Member

Description

Fix assert delivery test.
Move check_certificate_delivery to test sdk crate.

Fixes TP-767

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko requested a review from a team as a code owner October 26, 2023 15:15
@atanmarko atanmarko requested review from dvdplm and Freyskeyd October 26, 2023 15:15
@atanmarko atanmarko self-assigned this Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (74babd1) 59.84% compared to head (a17ddff) 60.42%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   59.84%   60.42%   +0.57%     
==========================================
  Files         230      230              
  Lines       11985    12013      +28     
==========================================
+ Hits         7173     7259      +86     
+ Misses       4812     4754      -58     
Files Coverage Δ
crates/topos-test-sdk/src/lib.rs 0.00% <ø> (ø)
crates/topos/tests/push-certificate.rs 100.00% <ø> (ø)
crates/topos/src/components/tce/mod.rs 15.74% <0.00%> (+0.24%) ⬆️
...os/src/components/tce/services/push_certificate.rs 58.38% <38.29%> (+58.38%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atanmarko atanmarko requested review from Freyskeyd and dvdplm October 27, 2023 09:49
@atanmarko atanmarko merged commit 903a589 into main Oct 30, 2023
@atanmarko atanmarko deleted the fix/TP-767 branch October 30, 2023 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants