This repository was archived by the owner on Oct 31, 2024. It is now read-only.
feat: remove npm package generation #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
==========================================
- Coverage 61.07% 61.04% -0.04%
==========================================
Files 237 237
Lines 13248 13248
==========================================
- Hits 8091 8087 -4
- Misses 5157 5161 +4 ☔ View full report in Codecov by Sentry. |
dvdplm
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
@Freyskeyd Can you also handle updating npmjs.com to either purge the package or mark it as deprecated?
Freyskeyd
force-pushed
the
feature/TP-759
branch
from
78637f5 to
1d1a242
Compare
gruberb
approved these changes
Oct 17, 2023
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Freyskeyd
force-pushed
the
feature/TP-759
branch
from
1d1a242 to
507933d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The NPM package for the gRPC API isn't used any more.
PR Checklist: