Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

fix: const SocketAddrs for default values #329

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Oct 6, 2023

The TceConfig struct has default values used during deserializartion. No need to parse strings
for that and instead we can use const and create the SocketAddrs we need straight up.

@dvdplm dvdplm requested a review from a team as a code owner October 6, 2023 07:57
@dvdplm dvdplm requested review from Freyskeyd and gruberb October 6, 2023 07:57
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7d0416e) 60.81% compared to head (b356929) 60.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   60.81%   60.83%   +0.01%     
==========================================
  Files         225      225              
  Lines       12177    12189      +12     
==========================================
+ Hits         7406     7415       +9     
- Misses       4771     4774       +3     
Files Coverage Δ
crates/topos/src/config/tce.rs 65.57% <100.00%> (+2.41%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hadjiszs hadjiszs merged commit e4b6bfc into main Oct 9, 2023
@hadjiszs hadjiszs deleted the dp-const-socketaddr branch October 9, 2023 22:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants