-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
2918250
to
2247f2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a different take on #323.
I think this one is better.
Duplicate of #323 |
Ok lets then take this one |
I think it is cleaner for testing to stay with string representation of keys |
b0fd8b9
to
fdb1fa9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 60.52% 60.55% +0.02%
==========================================
Files 225 225
Lines 12049 12054 +5
==========================================
+ Hits 7293 7299 +6
+ Misses 4756 4755 -1
☔ View full report in Codecov by Sentry. |
@Freyskeyd @dvdplm This PR grows unnecessary complex. Could we switch back to much simpler variant #323? EDIT: I take back this observation. Lets merge this |
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
fdb1fa9
to
5640f97
Compare
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
df93320
to
9fe601e
Compare
Description
This PR is fixing an issue while trying to parse the private key into a
LocalWallet
, instead of trying to parsebytes
intout8 str
I directly use thebytes
to generate thewallet
.PR Checklist: