Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

test: adding precedence order test #303

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Conversation

Freyskeyd
Copy link
Member

Description

This PR adds a non regression test on the precedence check order of source stream certificatees

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner September 13, 2023 07:31
Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dvdplm
Copy link
Contributor

dvdplm commented Nov 7, 2023

@Freyskeyd Is this PR still relevant or can we close it?

@Freyskeyd Freyskeyd force-pushed the fix/precedence-order-test branch from a5e090b to a7aab04 Compare November 17, 2023 13:22
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd force-pushed the fix/precedence-order-test branch from a7aab04 to 1ccd254 Compare November 17, 2023 13:56
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (591180d) 59.82% compared to head (1ccd254) 62.63%.
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   59.82%   62.63%   +2.80%     
==========================================
  Files         230      218      -12     
  Lines       11991    11876     -115     
==========================================
+ Hits         7174     7438     +264     
+ Misses       4817     4438     -379     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvdplm dvdplm merged commit 38cc514 into main Nov 18, 2023
@dvdplm dvdplm deleted the fix/precedence-order-test branch November 18, 2023 08:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants