Fix flakines of mutating webhook #280
Merged
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshipp
force-pushed
the
improve-ready
branch
2 times, most recently
from
059c90b
to
4760eaa
Compare
toshipp
changed the title
toshipp
force-pushed
the
improve-ready
branch
2 times, most recently
from
6027a0c
to
e6814ee
Compare
We observed that creating PVC failed because a mutating webhook does not work properly. To avoid that, wait for it working. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
ushitora-anqou
approved these changes
Aug 22, 2024
satoru-takeuchi
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix the flakiness found on #279