Increment failure metric for Kubernetes API client #263
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Addison <lukeaddison785@gmail.com>
dippynark
force-pushed
the
enable-kubernetes-api-client-metrics
branch
from
69f725b
to
000b8eb
Compare
ushitora-anqou
approved these changes
Jun 20, 2024
satoru-takeuchi
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kubernetes API client runner currently does not increment the metric client failure metric if there is a failure.
This PR fixes this to match with the Prometheus client:
pvc-autoresizer/internal/runners/prometheus_client.go
Line 84 in fa8cd0f
FYI I saw the KubernetesClientFailTotal metric, but I am assuming this should be reserved for listing PVCs etc. rather than for retrieving metrics