Use Github App token to create chart release PR #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peng225
commented
Nov 17, 2023
peng225
commented
- fix deprecated notation of app-id and private-key
- use Github App token to create chart release PR
cf. https://github.com/actions/create-github-app-token/blob/0f3b4d7df99b1af7cb8596ba4f855d6de4155aa5/action.yml#L14-L21 Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
When PR is created by using GITHUB_TOKEN, the workflows for the PR are not triggered. This commit fixes the problem. Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
daichimukai
approved these changes
Nov 20, 2023
satoru-takeuchi
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.