Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the CHANGELOG.md #217

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

peng225
Copy link
Contributor

@peng225 peng225 commented Oct 17, 2023

Stop using the CHANGELOG.md,
and use release notes instead.

Similar PR for topolvm: topolvm/topolvm#765

Signed-off-by: Shinya Hayashi shinya-hayashi@cybozu.co.jp

@peng225 peng225 requested a review from a team as a code owner October 17, 2023 05:21
@peng225 peng225 marked this pull request as draft October 17, 2023 05:22
@peng225 peng225 force-pushed the auto-generate-release-note branch 3 times, most recently from 403f91a to 5aeeefe Compare October 17, 2023 09:00
@peng225 peng225 marked this pull request as ready for review October 17, 2023 09:17
@@ -8,94 +8,83 @@ Versioning

Follow [semantic versioning 2.0.0][semver] to choose the new version number.

Prepare change log entries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes will be generated by release API automatically and the format of it doesn't look guaranteed. We only need to confirm that the output is correct regardless of the format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it in the similar manner as topolvm/pie#90 (comment) .

Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
@satoru-takeuchi satoru-takeuchi merged commit 986c918 into main Oct 20, 2023
7 checks passed
@satoru-takeuchi satoru-takeuchi deleted the auto-generate-release-note branch October 20, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants