reconcile: do not resize volume if failed to get inode stats #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daichimukai
force-pushed
the
controller/dont-resize-if-failed-to-get-some-metrics
branch
from
3eda503
to
fc7717b
Compare
daichimukai
force-pushed
the
controller/dont-resize-if-failed-to-get-some-metrics
branch
from
fc7717b
to
6c37b0a
Compare
The pvc-autoresizer decides whether each volume needs to be resized based on volume stats. This stats consist of available bytes, capacity, free inode count and all inode counts. The controller gets these values from prometheus metrics. Without this patch, if metrics lack inodes counts for some target volumes, decision on resize necessity are done as if the lacking values are zero. This causes unnecessary resizes for such volumes, and may continues to resize up to the volume storage limit. This patch changes the reconciler to resize volumes only if the controller succeeded to get all four volume stats. Fixes: f7e1be3 ("Add inode checking feature")
daichimukai
force-pushed
the
controller/dont-resize-if-failed-to-get-some-metrics
branch
3 times, most recently
from
734c8dd
to
4d33163
Compare
The e2e test depends on topolvm's example which had flakiness due to
insufficient wait for webhook readiness. This is addressed in topolvm
commit 31f8d5329c7e ("example: wait for topolvm controller mutating
webhook to become ready"). Use this commit if possible to reduce CI
flakiness.
daichimukai
force-pushed
the
controller/dont-resize-if-failed-to-get-some-metrics
branch
from
4d33163
to
35410dd
Compare
daichimukai
requested review from
a team,
toshipp and
satoru-takeuchi
and removed request for
a team
toshipp
approved these changes
Jun 23, 2022
satoru-takeuchi
approved these changes
Jun 24, 2022
satoru-takeuchi
deleted the
controller/dont-resize-if-failed-to-get-some-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pvc-autoresizer decides whether each volume needs to be resized based on volume stats. This stats consists of available bytes, capacity, free inode count and all inode counts. The controller gets these values from prometheus metrics.
Without this patch, if metrics lack inodes counts for some target volumes, decision on resize necessity are done as if the lacking values are zero. This causes unnecessary resize for such volumes, and may continues to resize up to volume storage limit.
This patch changes reconciler to resize volume only if controller succeeded to get all four volume stats.
Fixes: #118
Edit: I also updated TopoLVM version to reduce CI flakiness.