fix clean target of e2e/Makefile #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daichimukai
force-pushed
the
fix-e2e-make-clean
branch
from
de5bce3
to
cfe0cf0
Compare
toshipp
requested review from
a team,
toshipp,
satoru-takeuchi and
cupnes
and removed request for
a team and
toshipp
e2e/Makefile
Outdated
| @@ -92,6 +92,12 @@ kube-prometheus: | |||
|
|
|||
| .PHONY: clean | |||
| clean: stop-lvmd | |||
| for d in $$($(SUDO) find $(TMPDIR) -type f); do \ | |||
There was a problem hiding this comment.
Shouldn't it be "-type d"?
There was a problem hiding this comment.
"type -f" is correct. There are only file mount points left because the directory mount points are already unmounted here (called by make stop-lvmd -> make -C $(TMPDIR)/topolvm/example stop-lvmd -> make -C $(TMPDIR)/topolvm/example shutdown-kind)
https://github.com/topolvm/topolvm/blob/e00d2f66180b9058e3c78268ce095de34805291f/example/Makefile#L76-L80
The variable name "d" may be changed to "f".
There was a problem hiding this comment.
I've changed variable name d to f.
satoru-takeuchi
previously approved these changes
Mar 9, 2022
e2e/Makefile
Outdated
| @@ -92,6 +92,12 @@ kube-prometheus: | |||
|
|
|||
| .PHONY: clean | |||
| clean: stop-lvmd | |||
| for d in $$($(SUDO) find $(TMPDIR) -type f); do \ | |||
cupnes
previously approved these changes
Mar 9, 2022
`make -C e2e clean` fails with the following error: rm: cannot remove '/tmp/autoresizer/controller/pods': Permission denied rm: cannot remove '/tmp/autoresizer/worker/pods': Permission denied make: *** [Makefile:95: clean] Error 1 Even if executing with sudo, we get something like: rm: cannot remove '/tmp/autoresizer/worker/pods/78b7ad42-aeb2-48b3-8c01-ef37cba63a00/volume-subpaths/web-config/prometheus/4': Device or resource busy rm: cannot remove '/tmp/autoresizer/worker/pods/c4169fcb-6297-4053-9faa-9ae965962f3b/volume-subpaths/web-config/prometheus/4': Device or resource busy make: *** [Makefile:95: clean] Error 1 These files are mount points. To teardown properly, unmount these before removing TMPDIR.
daichimukai
force-pushed
the
fix-e2e-make-clean
branch
from
cfe0cf0
to
90c985f
Compare
cupnes
approved these changes
Mar 9, 2022
satoru-takeuchi
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make -C e2e cleanfails with the following error:Even if executing with sudo, we get something like:
These files are mount points. To teardown properly, unmount these before removing TMPDIR.