[WIP] Path Mapping Barycenters #1025
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Distance. Branch Mapping Distance still buggy.
…t/ttk into bdi-ed_clustering
…into bdi-ed_clustering
…t working for join trees.
…di-ed_clustering
…into bdi-ed_clustering
|
Wonderful, thanks a lot Florian!
|
|
Yes, I'm on it! |
|
@julien-tierny If the CI runs through, please remember to wait for the remaining changes by @MatPont to be pushed before merging into dev. |
|
I created the accompanying ttk-data PR: topology-tool-kit/ttk-data#162 |
julien-tierny
changed the title
|
work in progress, see topology-tool-kit/ttk-data#162 |
… the path mapping distance
…ath-mapping-preprocessing
|
I think all issues are fixed now. Can you have another look, @julien-tierny? Also, there seems to be a problem with the macos builds in the CI. Is this a problem from our side or an issue of the CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the path mapping distance to the MergeTreeBarycenter, MergeTreeClustering and MergeTreeTemporalReduction modules. Furthermore, the PlanarGraphLayout has been adapted to also enable a "path based layout" for merge trees. It also contains some bug fixes, additions and minor refactorings for other modules related to merge tree edit distances, e.g. when using BDIEDs in MergeTreeDistanceMatrix, it is now possible to apply the preprocessing steps also available for other distances.
In essence, this PR adds the code for the VIS23 paper "Merge Tree Geodesics and Barycenters with Path Mappings" and further related adaptations.
Some further changes are still pending and will be added by @MatPont soon. So please don't merge until they are finished.
An accompanying ttk-data PR will come soon, too.