Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Possible integration with nvm? #900

Closed
noahnu opened this issue Dec 23, 2020 · 1 comment · Fixed by #901
Closed

Possible integration with nvm? #900

noahnu opened this issue Dec 23, 2020 · 1 comment · Fixed by #901
Labels
discussion Open for discussion enhancement New feature or request released Pull request has been successfully deployed

Comments

@noahnu
Copy link
Contributor

noahnu commented Dec 23, 2020

Is your feature request related to a problem? Please describe.

yvm shims yarn so executing yarn will always use the right yarn version. Since we're already shimming yarn, it'd be nice if there was some optional nvm integration, such that the shim would also ensure yvm is run using the correct node version.

Describe the solution you'd like

Have an optional YVM_NVM_INTEGRATION=1 env flag to use nvm to grab the correct node path that then executes yvm.

Describe alternatives you've considered

A separate tool/project, or reliance on various terminal hooks.

Additional Context

If you're using yvm, there's a good chance you're using nvm. yarn is also used as a task runner via the scripts property of a package.json, and so you want it to use the correct node version.
@noahnu noahnu added enhancement New feature or request discussion Open for discussion labels Dec 23, 2020
@noahnu noahnu mentioned this issue Dec 23, 2020
Merged
2 tasks
noahnu pushed a commit that referenced this issue Dec 31, 2020
feat: add custom bootstrap script support, close #900 (#901)
70c831a
iamogbz pushed a commit that referenced this issue Dec 31, 2020
@semantic-release-bot
chore(release): 4.1.0 [skip ci]
b9c5b4d 
# [4.1.0](v4.0.1...v4.1.0) (2020-12-31)

### Features

* add custom bootstrap script support, close [#900](#900) ([#901](#901)) ([70c831a](70c831a))
@iamogbz
Copy link
Contributor

iamogbz commented Dec 31, 2020

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@iamogbz iamogbz added the released Pull request has been successfully deployed label Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
discussion Open for discussion enhancement New feature or request released Pull request has been successfully deployed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add custom bootstrap script support tophat/yvm
2 participants
@noahnu @iamogbz