fix: consider TMUX_PLUGIN_MANAGER_PATH when searching tpm binary

[SteveLauC]

What does this PR do

Before this PR, when updating tmux plugins, we only look for the update binary in its default location. The actual location can be altered via environment variable TMUX_PLUGIN_MANAGER_PATH so it should be considered as well.

fixes #832

Standards checklist

• The PR title is descriptive.
• I have read CONTRIBUTING.md
• Optional: I have tested the code myself

[SteveLauC]

https://github.com/SteveLauC/topgrade/releases/tag/pr835

There is a build for linux with this patch included, @rubiin, welcome to give it a test.

[rubiin]

I will give it a try asap

[rubiin]

Tried but doesnt do anything

[rubiin]

[SteveLauC]

Hi, would you like to show me where Topgrade should look for the update binary if TMUX_PLUGIN_MANAGER_PATH is set? Let's assume it is set to /tmp:

$ export TMUX_PLUGIN_MANAGER_PATH=/tmp

Then where is the update binary?

[rubiin]

seems to be located in this dir

[SteveLauC]

You have TMUX_PLUGIN_MANAGER_PATH set to

~/.config/tmux/plugins/tpm,

and the update_plugins binary is at

~/.config/tmux/plugins/tpm/bin/install_plugins/tpm/bin

so Topgrade should look for $TMUX_PLUGIN_MANAGER_PATH/bin/install_plugins/tpm/bin/update_plugins if the variable is set, right?

[rubiin]

https://github.com/tmux-plugins/tpm/blob/master/docs/automatic_tpm_installation.md
from the docs , TMUX_PLUGIN_MANAGER_PATH should point to the .config/tmux/plugins/tpm

that is to say the root tpm folder

so Topgrade should look for $TMUX_PLUGIN_MANAGER_PATH/bin/install_plugins/tpm/bin/update_plugins
which is correct

[SteveLauC]

https://github.com/SteveLauC/topgrade/releases/tag/pr835

There is a build for linux with this patch included, @rubiin, welcome to give it a test.

Attached Topgrade build updated, welcome to give it another test.

[rubiin]

sure will get back to you

[rubiin]

Working fine now, before that tmux step would have been escaped :) LGTM