Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Poetry #790

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed

  • Optional: The --dry-run option works with this step

  • Optional: The --yes option works with this step if it is supported by
    the underlying command

    cc @MisileLab, does this tool have something like $ poetry self update --yes?

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@SteveLauC
Copy link
Member Author

Do you want a binary to test, I can give you a binary of the following platforms:

  • Linux amd64 musl
  • macOS aarch

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 4.26%. Comparing base (767f0d9) to head (169668f).

Files Patch % Lines
src/steps/generic.rs 0.00% 5 Missing ⚠️
src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #790      +/-   ##
========================================
- Coverage   6.91%   4.26%   -2.65%     
========================================
  Files         37      33       -4     
  Lines      11645    5935    -5710     
========================================
- Hits         805     253     -552     
+ Misses     10840    5682    -5158     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveLauC SteveLauC linked an issue May 6, 2024 that may be closed by this pull request
@MisileLab
Copy link
Contributor

Standards checklist:

* [x]  The PR title is descriptive.

* [x]  I have read `CONTRIBUTING.md`

* [x]  The code compiles (`cargo build`)

* [x]  The code passes rustfmt (`cargo fmt`)

* [x]  The code passes clippy (`cargo clippy`)

* [x]  The code passes tests (`cargo test`)

* [ ]  _Optional:_ I have tested the code myself

For new steps

* [x]  _Optional:_ Topgrade skips this step where needed

* [x]  _Optional:_ The `--dry-run` option works with this step

* [ ]  _Optional:_ The `--yes` option works with this step if it is supported by
  the underlying command
  cc @MisileLab, does this tool have something like `$ poetry self update --yes`?

If you developed a feature or a bug fix for someone else and you do not have the means to test it, please tag this person here.

I just see that checklist now, but I think poetry's update is non-interact, so it doesn't need yes option.

@SteveLauC
Copy link
Member Author

Would you like to give this PR a test?

@SteveLauC SteveLauC force-pushed the feat/poetry_support branch from 169668f to 9e70107 Compare July 7, 2024 02:35
@SteveLauC SteveLauC merged commit 960b14f into topgrade-rs:main Jul 7, 2024
@SteveLauC SteveLauC deleted the feat/poetry_support branch July 7, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could you support poetry?
2 participants