Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CONTRIBUTING.md & config.example.toml #458

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Jun 1, 2023

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md

What does this PR do

  1. Update the example cases given in CONTRIBUTING.md where arguments in addition to ctx are required

    The old example is not suitable as cleanup is included in ExecutionContext, we don't need that cleanup argument, the related code will be fixed in refactor: make update fn take &ExectionContext & put update fn together #457

  2. Fix some typos in CONTRIBUTING.md

  3. Uncomment [include] section in config.example.toml

@s34m s34m merged commit a0ff565 into topgrade-rs:master Jun 1, 2023
@SteveLauC SteveLauC deleted the contributing branch June 1, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants