Skip to content

Fix bug where copilots can't assign tasks to themselves, even before activation #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix bug where copilots can't assign tasks to themselves, even before activation #1581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0c393d
Mark as complete not working at bottom
jmgasper Nov 9, 2023
0760c78
Fix for https://github.com/topcoder-platform/work-manager/issues/1580
jmgasper Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/actions/challenges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,10 @@ export function updateChallengeDetails (challengeId, challengeDetails, projectId
if (hasMilestone) {
delete challengeDetails.milestoneId
}
if (challengeDetails.status === 'Completed') {
// Cannot update prizeSets for challenges with status: Completed!
delete challengeDetails.prizeSets
}
return updateChallenge(challengeId, challengeDetails).then(async challenge => {
if (hasMilestone) {
if (milestoneId && milestoneId !== -1) {
Expand Down
16 changes: 7 additions & 9 deletions src/components/ChallengeEditor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1576,15 +1576,13 @@ class ChallengeEditor extends Component {
<div className={styles.bottomContainer}>
{!isLoading && <LastSavedDisplay timeLastSaved={draftChallenge.data.updated} />}
{!isLoading && (!isActive) && (!isCompleted) && <div className={styles.buttonContainer}>
{(!preventCopilotFromActivatingTask) && (
<div className={styles.button}>
{!this.state.hasValidationErrors ? (
<PrimaryButton text={isSaving ? 'Saving...' : 'Save Draft'} type={'info'} onClick={this.createDraftHandler} />
) : (
<PrimaryButton text={'Save Draft'} type={'disabled'} />
)}
</div>
)}
<div className={styles.button}>
{!this.state.hasValidationErrors ? (
<PrimaryButton text={isSaving ? 'Saving...' : 'Save Draft'} type={'info'} onClick={this.createDraftHandler} />
) : (
<PrimaryButton text={'Save Draft'} type={'disabled'} />
)}
</div>
{
(
isDraft &&
Expand Down