Skip to content

fix: modifed av scan review type id in development config #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix: modifed av scan review type id in development config #377

merged 1 commit into from
Jul 9, 2025

Conversation

@hentrymartin
Copy link
Collaborator

@hentrymartin hentrymartin commented Jul 4, 2025 •
edited
Loading

What's in this PR?

  • Seems like in develop(at least), the virus scan type id is different than the config for development config. This makes the virus scan as one of the valid reviews in mmSubmissions array.
  • I've modified the configured AV_SCAN_SCORER_REVIEW_TYPE_ID to "1297f2db-687d-4ac8-bf9c-78b6df1b1281" which is what returned in the review array(you can see the screenshot below)
Screenshot 2025-07-04 at 22 24 34

@hentrymartin hentrymartin requested a review from jmgasper July 4, 2025 20:57
@hentrymartin
Copy link
Collaborator Author

hentrymartin commented Jul 7, 2025

@jmgasper Can you please review this PR?

@hentrymartin hentrymartin merged commit 4bef074 into develop Jul 9, 2025
1 check passed
@hentrymartin hentrymartin deleted the pm-1358 branch July 9, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmgasper jmgasper jmgasper approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hentrymartin @jmgasper