Restful Invites #517
Merged
Restful Invites #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submission For Topcoder Project Service - Update Invite Endpoints part1
# Conflicts: # docs/Project API.postman_collection.json
Fixed units in src/projectMembers/create.spec.js
- also fix unit tests after enabling masking emails
update invite endpoint part2
# Conflicts: # package.json # src/routes/projectMemberInvites/create.js # src/routes/projectMemberInvites/get.js # src/routes/projectMemberInvites/list.js
# Conflicts: # src/util.js
# Conflicts: # src/routes/projectMemberInvites/create.js # src/routes/projectMemberInvites/create.spec.js
Permissions logic for updating and deleting permissions has been clarified. Also, fixed issue when project managers cannot remove invites for other people.
we had the logic which removed "email" field from the allowed fields for non-admins this logic has been rewritten to add "email" field to the allowed fields for admins to avoid accidental "email" leaking
stop retrieving additional fields which has been added to ES for members as they can be outdated also, returning email from ES may leak it, while email should be only returned to admins as controlled by "getObjectsWithMemberDetails" method
…ocessing on invite(s) with following constraints: 1. email field will be omitted from invite if the invite has defined userId 2. email field (if existed) will be masked UNLESS current user has admin permissions OR current user created this invite - also apply this post-processing when creating invite.
Post-Processing Invites
…m/tc-project-service into feature/restful-invites
# Conflicts: # src/util.js
This was referenced Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.