Skip to content

test log #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

test log #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/mcp/tools/challenges/queryChallenges.tool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ export class QueryChallengesTool {
this.logger.error(
`Failed to fetch challenges from Topcoder API: ${challenges.statusText}`,
);
try {
this.logger.error(await challenges.json());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium
correctness
Consider checking if challenges has a valid JSON response before attempting to parse it. This can prevent unnecessary exceptions and improve error handling.

} catch (e) {
this.logger.error('Failed to log challenge error');
}

// Return an error response if the API call fails
return {
Expand Down Expand Up @@ -108,7 +113,7 @@ export class QueryChallengesTool {
},
};
} catch (error) {
this.logger.error(`Error fetching challenges: ${error.message}`);
this.logger.error(`Error fetching challenges: ${error.message}`, error);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium
security
Passing the entire error object to the logger can be beneficial for debugging as it may include additional context like stack traces. Ensure that the logger is configured to handle and securely store this information, especially if it contains sensitive data.

return {
content: [
{
Expand Down