Skip payments for MM reviewers #121
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| challenge: Challenge, | ||
| reviewers: ChallengeResource[], | ||
| ): Promise<PaymentPayload[]> { | ||
| // skip reviewers payment for Marathon Match challenges |
There was a problem hiding this comment.
[❗❗ correctness]
The current logic skips payment for all reviewers if the challenge is a 'Marathon Match' in the 'Data Science' track. Ensure that this behavior is intended, as it might lead to reviewers not being compensated for their work. Consider adding a test case to verify this behavior.
| attachments: any[]; // Replace with type if available | ||
| track: string; | ||
| type: string; | ||
| track: { name: string }; |
There was a problem hiding this comment.
[❗❗ correctness]
Changing track from a string to an object with a name property could impact any existing logic that expects track to be a simple string. Ensure that all usages of track are updated accordingly to prevent runtime errors.
| track: string; | ||
| type: string; | ||
| track: { name: string }; | ||
| type: { name: string }; |
There was a problem hiding this comment.
[❗❗ correctness]
Similar to track, changing type from a string to an object with a name property requires a thorough check of all code that interacts with type to avoid potential issues with existing logic.
No description provided.