Fix challenge fetch #120
Merged
Fix challenge fetch #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // Use the URL constructor to avoid path traversal/SSRF risks. | ||
| const baseUrl = TC_API_BASE.endsWith('/') ? TC_API_BASE.slice(0, -1) : TC_API_BASE; | ||
| const requestUrl = new URL(`/challenges/${challengeId}`, baseUrl).toString(); | ||
| const requestUrl = `${TC_API_BASE}/challenges/${challengeId}`; |
There was a problem hiding this comment.
[correctness]
Using string concatenation for URL construction can lead to issues such as double slashes or missing slashes, especially if TC_API_BASE ends with a slash. Consider using a more robust method to ensure the URL is constructed correctly, such as checking for trailing slashes or using a library designed for URL manipulation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reversing previous work to url builder because using url constructor with base url will strip out any url paths from the base url.