Skip to content

Validate that provided challengeId param is a valid uuid #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

Validate that provided challengeId param is a valid uuid #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/api/challenges/challenges.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Controller, Post, Param, HttpCode, HttpStatus } from '@nestjs/common';
import { Controller, Post, Param, HttpCode, HttpStatus, BadRequestException } from '@nestjs/common';
import { isUUID } from 'class-validator';
import {
ApiOperation,
ApiParam,
Expand Down Expand Up @@ -42,6 +43,10 @@ export class ChallengesController {
@Param('challengeId') challengeId: string,
@User() user: UserInfo,
): Promise<ResponseDto<string>> {
if (!isUUID(challengeId)) {
Copy link

@github-actions github-actions bot Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
Consider using a more specific exception class or error message to provide additional context about the validation failure. This can help with debugging and logging.

throw new BadRequestException('Invalid challengeId provided! Uuid expected!');
}

const result = new ResponseDto<string>();

try {
Expand Down