[HOTFIX] Fix nan for release date #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acy (omit conversion to nan)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| amount: body.paymentAmount, | ||
| releaseDate: formatDate(new Date(body.releaseDate)), | ||
| releaseDate: | ||
| body.releaseDate && formatDate(new Date(body.releaseDate)), |
There was a problem hiding this comment.
[correctness]
The conditional logic here is correct for omitting releaseDate when body.releaseDate is undefined. However, consider explicitly checking for null as well, since null is a common value that might be used to represent an absent date. This would ensure that releaseDate is omitted in both undefined and null cases.
There was a problem hiding this comment.
I think we're fine for now since we don't plan to expand this functionality (we'll remove it soon), and for now we're not sending null
kkartunov
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating status and releaseDate is undefined, omit it when sending to legacy.
previously:
fix:
