Skip to content

PM-2596 - Improved description for copilot & checkpoint winner payments #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

PM-2596 - Improved description for copilot & checkpoint winner payments #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/api/challenges/challenges.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export class ChallengesService {
description:
challenge.type === 'Task'
? challenge.name
: `${challenge.name} - ${placeToOrdinal(winner.placement)} Place`,
: `${challenge.name} - ${type === WinningsCategory.CONTEST_CHECKPOINT_PAYMENT ? 'Checkpoint ' : ''}${placeToOrdinal(winner.placement)} Place`,
Copy link

@github-actions github-actions bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The variable type is used here without being declared or initialized in the visible context. Ensure that type is correctly defined and available in this scope to avoid potential runtime errors.

}));
}

Expand Down Expand Up @@ -220,6 +220,7 @@ export class ChallengesService {
amount: copilotPrizes[0].value,
userId: copilot.memberId.toString(),
type: WinningsCategory.COPILOT_PAYMENT,
description: `${challenge.name} - Copilot payment`,
Copy link

@github-actions github-actions bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ security]
Consider sanitizing challenge.name to prevent potential injection attacks if this value is used in contexts that could be vulnerable to such attacks.

}));
}

Expand Down